fix: correct server.js path in Dockerfile for standalone build#3107
fix: correct server.js path in Dockerfile for standalone build#3107guangyang1206 wants to merge 1 commit into
Conversation
The Dockerfile was pointing to apps/web/client/server.js which doesn't exist. The standalone build outputs to .next/standalone/apps/web/client/server.js. Fixes onlook-dev#3046
|
@guangyang1206 is attempting to deploy a commit to the Onlook Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Dockerfile's container startup command is updated to run the Next.js standalone server from the build output path ( ChangesDockerfile Server Startup Path
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Dockerfile was pointing to apps/web/client/server.js which doesn't exist. The standalone build outputs to .next/standalone/apps/web/client/server.js.
Fixes #3046
Description
The Dockerfile was incorrectly pointing to
apps/web/client/server.jswhich doesn't exist in the repository. When using standalone build output (STANDALONE_BUILD=true), Next.js outputs the server file to.next/standalone/apps/web/client/server.js.This caused Docker builds to fail with error: "Module not found 'apps/web/client/server.js'"
Related Issues
Fixes #3046
Type of Change
Testing
Additional Notes
The
start:standalonescript in package.json already correctly references.next/standalone/apps/web/client/server.js, but the Dockerfile was using the wrong path.Summary by CodeRabbit