Abstracted path.Matcher to Matcher interface#8
Open
sampaioletti wants to merge 2 commits intoolebedev:masterfrom
Open
Abstracted path.Matcher to Matcher interface#8sampaioletti wants to merge 2 commits intoolebedev:masterfrom
sampaioletti wants to merge 2 commits intoolebedev:masterfrom
Conversation
|
Is there any reason why this is not getting merged? |
olebedev
requested changes
Sep 11, 2020
Owner
olebedev
left a comment
olebedev
left a comment
There was a problem hiding this comment.
Intention looks good to me. I would prefer to keep the API non-broken. I've left a comment below, ptal
| } | ||
| // optionally include a matcher to use or nil to use the default | ||
| // which implements path.Match() from the system library | ||
| func New(capacity uint, matcher Matcher) *Emitter { |
Owner
There was a problem hiding this comment.
How about to create another function/constructor, like:
func NewWithMatcher(capacity uint, matcher Matcher) *Emitter {or make it a variadic function, like:
func New(capacity uint, matcher ...Matcher) *Emitter {rather than introducing a broken change?
I would prefer to don't change the existing library's API if it's not a but fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had a project where I was using your library, but needed different matching than path.Match (our strings have "/" in them, but are not paths).
So I pulled the match functionality out into an interface to make it easier to override. Thought I'd push it back and see if it was useful.
Thanks for the cool library.