[Fix] helpers are now available in NestedAttribute#503
[Fix] helpers are now available in NestedAttribute#503okuramasafumi wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
===========================================
- Coverage 97.73% 46.87% -50.86%
===========================================
Files 14 13 -1
Lines 661 640 -21
Branches 177 174 -3
===========================================
- Hits 646 300 -346
- Misses 15 340 +325 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pgiblock
left a comment
There was a problem hiding this comment.
Thanks for addressing the issue I was experiencing. The code does not run for me (Ruby 3.4.8, Rails 8.1).
| def assign_resource(nesting, key_transformation, block, helper) | ||
| @resource = if block | ||
| charged_resource_class(helper, key_transformation, block) | ||
| Alba.resource_class(helper: helper, key_transformation: key_transformation, &block) |
There was a problem hiding this comment.
This fails for me. I get:
wrong number of arguments (given 1, expected 0)
Alba.rb defines the method (with no arguments) as:
def resource_class(&block)
Fix #495