[ocsigen-start.8.0.0] Constrain ocsigen-i18n < 5.0.0#29644
Closed
balat wants to merge 1 commit intoocaml:masterfrom
Closed
[ocsigen-start.8.0.0] Constrain ocsigen-i18n < 5.0.0#29644balat wants to merge 1 commit intoocaml:masterfrom
balat wants to merge 1 commit intoocaml:masterfrom
Conversation
ocsigen-i18n 5.0.0 generates [@@deriving json] directly in --eliom mode. All ocsigen-start versions that depend on ocsigen-i18n have a sed post-processing step that also adds [@@deriving json], causing duplication and a compilation error. Add < 5.0.0 upper bound on all affected versions (4.4.0 through 8.0.0). Also remove duplicate ocsigen-i18n dependency entries.
balat
force-pushed
the
fix-ocsigen-start-i18n-constraint
branch
from
35f13e9 to
7875b48
Compare
Contributor
Author
|
Superseded by #29643 which now includes both the ocsigen-i18n 5.0.0 release and the ocsigen-start constraints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ocsigen-i18n 5.0.0 now generates
[@@deriving json]directly in--eliommode. ocsigen-start 8.0.0 has asedpost-processing step that also adds[@@deriving json], causing duplication and a compilation error.This adds an upper bound
< 5.0.0on theocsigen-i18ndependency to prevent the incompatible combination. Also removes the duplicateocsigen-i18ndependency entry (>= 3.7.0).