Skip to content

fix: sanitize page titles and display names used as folder path segments in OneNote importer #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaron-meyers wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: sanitize page titles and display names used as folder path segments in OneNote importer #503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b82b6c4
Sanitize entity names used as folder path segments in OneNote importe…
Copilot Feb 16, 2026
c7de20a
address review comments
aaron-meyers Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/formats/onenote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { OnenotePage, SectionGroup, User, PublicError, Notebook, OnenoteSection } from '@microsoft/microsoft-graph-types';
import { DataWriteOptions, Notice, Setting, TFolder, htmlToMarkdown, ObsidianProtocolData, requestUrl, moment } from 'obsidian';
import { genUid, extractErrorMessage, parseHTML } from '../util';
import { genUid, extractErrorMessage, parseHTML, sanitizeFileName } from '../util';
import { FormatImporter } from '../format-importer';
import { ATTACHMENT_EXTS, AUTH_REDIRECT_URI, ImportContext } from '../main';
import { AccessTokenResponse } from './onenote/models';
Expand Down Expand Up @@ -727,7 +727,8 @@ export class OneNoteImporter extends FormatImporter {

getEntityPathNoParent(entityID: string, currentPath: string): string | null {
for (const notebook of this.notebooks) {
const path = this.getEntityPath(entityID, `${currentPath}/${notebook.displayName}`, notebook);
const sanitizedName = sanitizeFileName(notebook.displayName || 'Untitled Notebook');
const path = this.getEntityPath(entityID, `${currentPath}/${sanitizedName}`, notebook);
if (path) return path;
}
return null;
Expand Down Expand Up @@ -779,7 +780,8 @@ export class OneNoteImporter extends FormatImporter {
* ...Section/Example/Page.md and ...Section/Example/Lower level.md
*/
if (section.pages![i + 1] && section.pages![i + 1].level !== 0) {
returnPath = `${currentPath}/${page.title}`;
const sanitizedName = sanitizeFileName(page.title || 'Untitled');
returnPath = `${currentPath}/${sanitizedName}`;
}
else returnPath = currentPath;
}
Expand All @@ -789,7 +791,8 @@ export class OneNoteImporter extends FormatImporter {
// Iterate backward to find the parent page
for (let i = section.pages!.indexOf(page) - 1; i >= 0; i--) {
if (section.pages![i].level === page.level! - 1) {
returnPath += '/' + section.pages![i].title;
const sanitizedName = sanitizeFileName(section.pages![i].title || 'Untitled');
returnPath += '/' + sanitizedName;
break;
}
}
Expand All @@ -804,9 +807,10 @@ export class OneNoteImporter extends FormatImporter {
// Recursively search in section groups
let returnPath: string | null = null;
for (const sectionGroup of sectionGroups) {
if (sectionGroup.id === entityID) returnPath = `${currentPath}/${sectionGroup.displayName}`;
const sanitizedName = sanitizeFileName(sectionGroup.displayName || 'Untitled');
if (sectionGroup.id === entityID) returnPath = `${currentPath}/${sanitizedName}`;
else {
const foundPath = this.getEntityPath(entityID, `${currentPath}/${sectionGroup.displayName}`, sectionGroup);
const foundPath = this.getEntityPath(entityID, `${currentPath}/${sanitizedName}`, sectionGroup);
if (foundPath) {
returnPath = foundPath;
break;
Expand Down