feat: add CalDAV and CardDAV as recognized brands#104
Open
josecoelho wants to merge 2 commits intoobsidianmd:masterfrom
Open
feat: add CalDAV and CardDAV as recognized brands#104josecoelho wants to merge 2 commits intoobsidianmd:masterfrom
josecoelho wants to merge 2 commits intoobsidianmd:masterfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
CalDAV (Calendaring Extensions to WebDAV, RFC 4791) and CardDAV (vCard Extensions to WebDAV, RFC 6352) have mixed-case capitalization that needs to be preserved exactly. Added to brands (not acronyms) since the acronyms list uppercases tokens entirely. Fixes obsidianmd#103 Co-Authored-By: Claude Opus 4.6 <[email protected]>
josecoelho
force-pushed
the
add-caldav-brand
branch
from
4753121 to
2c20118
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CalDAVandCardDAVto theDEFAULT_BRANDSlist in the sentence-case ruleWhy
CalDAV (Calendaring Extensions to WebDAV, RFC 4791) and CardDAV (vCard Extensions to WebDAV, RFC 6352) are internet standards with specific capitalization — the "DAV" portion is an acronym for Distributed Authoring and Versioning.
WebDAVis already recognized in the acronyms list. CalDAV and CardDAV extend WebDAV but use mixed case (not all-caps), so they belong in the brands list.The review bot currently flags these as sentence case violations. I had to replace all "CalDAV" references with "calendar" in my plugin obsidian-tasks-caldav to pass the obsidian-releases review.
Fixes #103
🤖 Generated with Claude Code