feat(FileUpload): expose removeFile in slots#6492
Open
cydrickn wants to merge 1 commit into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughThe FileUpload component now exposes a removeFile(index?: number) callback through its scoped slots. The FileUploadSlots type is updated to include removeFile on the files, file, and file-trailing slot prop objects. The component template is changed to pass remove-file into the files slot and into each per-file file and file-trailing slot so slot consumers can remove files via the provided callback. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
7ca8a23 to
23dc0fc
Compare
removeFile in slots
benjamincanac
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6491
❓ Type of change
📚 Description
The
fileandfile-trailingslots inUFileUploaddid not expose theremoveFilefunction, making it impossible to trigger file removal from within a custom slot template.This change passes
removeFileas a slot prop to bothfileandfile-trailing, consistent with howfiles-topandfiles-bottomalready expose it. Users can now do:📝 Checklist