Stabilize note list text alignment on Windows#770
Closed
MizuCiaossu wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@nuttyartist another AI account that has the exact same issues as #769. What should we do with these?
like seriously wtf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boundingRect()heights, which vary with the actual glyphs renderedNoteListDelegateandNoteListDelegateEditorin sync so the persistent editor matches the normal row rendererFixes #164.
Why
The Windows alignment bug appears to come from using text-specific bounding boxes to position stacked note row labels. On some Windows font/DPI combinations, that can make row spacing depend on the glyphs in each note title/date/content, which leads to visually inconsistent alignment.
Testing
QFontMetrics::height()in the two note-list paint paths.