Update install_deps.sh for current version of zlib#18
Open
adriantich wants to merge 1 commit intonunofonseca:masterfrom
Open
Update install_deps.sh for current version of zlib#18adriantich wants to merge 1 commit intonunofonseca:masterfrom
adriantich wants to merge 1 commit intonunofonseca:masterfrom
Conversation
there was a 404 error for the version 1.2.13, this way it will download the current one
There was a problem hiding this comment.
Pull Request Overview
This PR updates the install_deps.sh script to fetch the latest zlib release instead of the now-missing v1.2.13, avoiding 404 errors during dependency installation.
- Switched from a hard-coded zlib 1.2.13 URL to the
current/zlib.tar.gzendpoint - Adjusted extraction and directory navigation to handle the dynamic version folder
| wget -c http://zlib.net/zlib-1.2.13.tar.gz | ||
| tar xvzf zlib-1.2.13.tar.gz | ||
| pushd zlib-1.2.13 | ||
| wget -c http://zlib.net/current/zlib.tar.gz |
There was a problem hiding this comment.
Consider using HTTPS for the download URL to ensure integrity and prevent man-in-the-middle tampering (e.g., https://zlib.net/current/zlib.tar.gz).
Suggested change
| wget -c http://zlib.net/current/zlib.tar.gz | |
| wget -c https://zlib.net/current/zlib.tar.gz |
| pushd zlib-1.2.13 | ||
| wget -c http://zlib.net/current/zlib.tar.gz | ||
| tar xvzf zlib.tar.gz | ||
| pushd zlib-* |
There was a problem hiding this comment.
[nitpick] Using a glob (zlib-*) can match unintended folders if leftovers exist. Capture the extracted directory name (e.g., parsing tar tzf ... | head -1) into a variable and pushd that explicitly for more reliable navigation.
Suggested change
| pushd zlib-* | |
| ZLIB_DIR=$(tar tzf zlib.tar.gz | head -1 | cut -f1 -d"/") | |
| pushd $ZLIB_DIR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there was a 404 error for the version 1.2.13, this way it will download the current one