Merged
Conversation
Un-exported the following dashboard symbols that are only used internally: - FIELD_TYPE_OPERATORS in field-type-operators.ts - RELATIVE_DATE_OPERATORS in field-type-operators.ts - EMPTY_SELECT_VALUE in select-option-utils.tsx - SchemaEditorFormValuesSchema in validation-schema.ts - CONSISTENT_TOAST_OPTIONS in sonner-helpers.tsx Co-authored-by: Adam Chmara <[email protected]>
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted. Your PR title is: Requirements:
Expected format: Details: PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed 5 unused exports from dashboard files that are only referenced internally within their own files.
Changes
apps/dashboard/src/components/conditions-editor/field-type-operators.tsFIELD_TYPE_OPERATORSgetOperatorsForFieldTypein the same fileapps/dashboard/src/components/conditions-editor/field-type-operators.tsRELATIVE_DATE_OPERATORSisRelativeDateOperatorin the same fileapps/dashboard/src/components/conditions-editor/select-option-utils.tsxEMPTY_SELECT_VALUEtoSafeValue/fromSafeValuein the same fileapps/dashboard/src/components/schema-editor/utils/validation-schema.tsSchemaEditorFormValuesSchemaeditorSchemaalias; direct import is unusedapps/dashboard/src/components/primitives/sonner-helpers.tsxCONSISTENT_TOAST_OPTIONSshowToast/showSuccessToast/showErrorToastin the same fileValidation
tsc --noEmit -p tsconfig.app.json(dashboard): passed (exit 0)Skipped findings
index.tsre-exports, template files underpackages/novu,enterprise/, config files,apps/webhookandapps/inbound-mail— all skip-listed)apps/dashboard/src/types/global.ts— global type declarations, skipped per policyapps/dashboard/src/context/region/*self-hosted*— wired via Vite alias, not safe to deleteFull knip report
Unused files (58)
Unused exports (414)
409 remaining unused exports across libs, apps/api, apps/dashboard, apps/worker, packages/novu, packages/add-inbox, packages/providers, and packages/shared.