Fix vm test not respecting disko.tests.extraConfig disko overwrites#1184
Open
BerriJ wants to merge 1 commit intonix-community:masterfrom
Open
Fix vm test not respecting disko.tests.extraConfig disko overwrites#1184BerriJ wants to merge 1 commit intonix-community:masterfrom
disko.tests.extraConfig disko overwrites#1184BerriJ wants to merge 1 commit intonix-community:masterfrom
Conversation
…devices into testConfigBooted.disko.devices
Member
|
This looks like the same changes I made in #480 however I think the correct approach is #1094 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Lassulus This should fix cases where users overwrite some disko configurations inside of
disko.tests.extraConfig. The docs on this setting state:Consider the following setting: You have
boot.initrd.systemd.enable = true;(systemd in Stage 1) and you have a disko config with luks like this:So usually you provide a passwordFile and when booting you just type that password.
However, for VM tests you want to unlock this luks partition non-interactively. So you:
/tmp/secret.keyduring bootsettings.keyFile = "/tmp/secret.keyso that cryptsetup uses the keyFile to unlock the partitionSo I expected this to work:
While nix repl does show:
Running
Will stop at the interactive password prompt.
With this PR, it will respect the keyFile setting correctly and auto-unlock.
See #1185 for a reproducible example.