Conversation
… tests - Fix isHighlightValid error by refactoring parsing logic to iterate noteHeading elements - Add text normalization function to handle non-breaking spaces, curly quotes, and dashes - Implement language-agnostic parsing using structural DOM elements instead of text content - Add comprehensive unit tests with Vitest/jsdom for French and English fixtures - Test first 5 highlights from each language to validate parsing consistency - Fix author parsing to properly trim and split multiple authors - Add lessons-learned documentation for future reference - Configure test environment with proper plugin handling This resolves the TypeError when parsing international Kindle exports and ensures robust parsing across different languages and character encodings.
…ugin - Load @tailwindcss/vite via dynamic import to avoid CJS/ESM interop - Load vite-plugin-logseq via createRequire to handle CommonJS - Move test config out of Vite config to avoid type errors - Keep all plugins enabled; no removals Refs: fix/fix-language-issues
nicdun
force-pushed
the
fix/fix-language-issues
branch
from
4d3624c to
aacb931
Compare
… headers - Introduce `groupBySectionHeader` boolean setting - Create chapter heading blocks (##) and nest highlights as children when enabled - Add helper functions for heading and child block creation - Keep original flat mode when setting is disabled - Add minimal test to validate grouping behavior Refs: #grouping
nicdun
force-pushed
the
fix/fix-language-issues
branch
from
aacb931 to
cbe7d57
Compare
nicdun
added a commit
that referenced
this pull request
Aug 30, 2025
* fix(parsing): resolve character encoding issues and add comprehensive tests - Fix isHighlightValid error by refactoring parsing logic to iterate noteHeading elements - Add text normalization function to handle non-breaking spaces, curly quotes, and dashes - Implement language-agnostic parsing using structural DOM elements instead of text content - Add comprehensive unit tests with Vitest/jsdom for French and English fixtures - Test first 5 highlights from each language to validate parsing consistency - Fix author parsing to properly trim and split multiple authors - Add lessons-learned documentation for future reference - Configure test environment with proper plugin handling This resolves the TypeError when parsing international Kindle exports and ensures robust parsing across different languages and character encodings. * ci: add PR workflow with commitlint, eslint, tests, and build; migrate configs to ESM * build(vite): support ESM-only tailwind plugin alongside CJS logseq plugin - Load @tailwindcss/vite via dynamic import to avoid CJS/ESM interop - Load vite-plugin-logseq via createRequire to handle CommonJS - Move test config out of Vite config to avoid type errors - Keep all plugins enabled; no removals Refs: fix/fix-language-issues * chore(tailwind): update tailwind to v4 * feat(output): add setting to group highlights by chapter with section headers - Introduce `groupBySectionHeader` boolean setting - Create chapter heading blocks (##) and nest highlights as children when enabled - Add helper functions for heading and child block creation - Keep original flat mode when setting is disabled - Add minimal test to validate grouping behavior Refs: #grouping
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 30, 2025
# [1.4.0](v1.3.0...v1.4.0) (2025-08-30) ### Features * **language-parsing:** language issues ([#609](#609)) ([727f6f7](727f6f7))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #345 and #523