Skip to content

fix(download): update download method for companion app integration#79

Merged
ngocjohn merged 2 commits intodevfrom
fix-download-from-app
Feb 20, 2026
Merged

fix(download): update download method for companion app integration#79
ngocjohn merged 2 commits intodevfrom
fix-download-from-app

Conversation

@ngocjohn
Copy link
Copy Markdown
Owner

Refactor the download functionality to utilize a dedicated fileDownload utility, improving the handling of downloads initiated from the companion app.

@ngocjohn ngocjohn self-assigned this Feb 20, 2026
@ngocjohn ngocjohn marked this pull request as ready for review February 20, 2026 14:24
Copilot AI review requested due to automatic review settings February 20, 2026 14:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors download behavior to use a shared fileDownload helper, aiming to improve handling of downloads initiated from the companion app.

Changes:

  • Added a fileDownload(href, filename) utility to centralize anchor-based downloads.
  • Updated the sidebar config code editor to use fileDownload for YAML downloads.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/utilities/dom-utils.ts Adds the new fileDownload helper for initiating browser downloads.
src/components/sidebar-dialog-code-editor.ts Switches YAML download logic to the new helper.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/sidebar-dialog-code-editor.ts
Comment thread src/utilities/dom-utils.ts
@ngocjohn ngocjohn merged commit 7571f2e into dev Feb 20, 2026
2 checks passed
@ngocjohn ngocjohn deleted the fix-download-from-app branch February 20, 2026 14:28
github-actions Bot pushed a commit that referenced this pull request Feb 20, 2026
## [3.0.2-beta.2](v3.0.2-beta.1...v3.0.2-beta.2) (2026-02-20)

### Bug Fixes

* **download:** update download method for companion app integration ([#79](#79)) ([7571f2e](7571f2e))
@github-actions
Copy link
Copy Markdown

πŸŽ‰ This PR is included in version 3.0.2-beta.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions Bot pushed a commit that referenced this pull request Feb 20, 2026
## [3.0.2](v3.0.1...v3.0.2) (2026-02-20)

### Bug Fixes

* **download:** update download method for companion app integration ([#79](#79)) ([7571f2e](7571f2e))
* **sidebar:** add method to handle sidebar DOM updates during Home Assistant state changes ([#76](#76)) ([d3c2833](d3c2833)), closes [#73](#73)
@github-actions
Copy link
Copy Markdown

πŸŽ‰ This PR is included in version 3.0.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants