Skip to content

fix(types): improve type safety of pollForToken #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix(types): improve type safety of pollForToken #7896

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c47be27
feat: improve type safety in command helpers
google-labs-jules[bot] Jan 26, 2026
e67042e
Merge branch 'main' into fix/type-safety-command-helpers-182307144016…
serhalp Feb 3, 2026
6b8dc3b
Merge branch 'main' into fix/type-safety-command-helpers-182307144016…
serhalp Feb 3, 2026
88b97f6
feat: improve type safety in command helpers
google-labs-jules[bot] Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/utils/command-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,19 +101,18 @@ export const pollForToken = async ({
return logAndThrowError('Could not retrieve access token')
}
return accessToken
} catch (error_) {
// @ts-expect-error TS(2571) FIXME: Object is of type 'unknown'.
if (error_.name === 'TimeoutError') {
} catch (error) {
if (error instanceof Error && error.name === 'TimeoutError') {
return logAndThrowError(
`Timed out waiting for authorization. If you do not have a ${chalk.bold.greenBright(
'Netlify',
)} account, please create one at ${chalk.magenta(
'https://app.netlify.com/signup',
)}, then run ${chalk.cyanBright('netlify login')} again.`,
)
} else {
return logAndThrowError(error_)
}

return logAndThrowError(error)
} finally {
spinner.stop()
spinner.clear()
Expand Down
Loading