Skip to content

build(types): improve type safety in some utils #7863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 7 commits into from
Closed

build(types): improve type safety in some utils #7863

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
218ca7a
feat(types): Improve type safety in leaf-node modules
google-labs-jules[bot] Jan 14, 2026
15fca8e
feat(types): Improve type safety in leaf-node modules
google-labs-jules[bot] Feb 3, 2026
5e7681b
Merge branch 'main' into fix/type-safety-improvements-122156949660204…
serhalp Feb 3, 2026
46e4030
feat(types): Improve type safety in leaf-node modules
google-labs-jules[bot] Feb 3, 2026
5ae13ae
fix(types): Improve type safety in src/utils/dev.ts
google-labs-jules[bot] Feb 3, 2026
ae9f721
Fix: Improve Type Safety in Utility Modules
google-labs-jules[bot] Feb 3, 2026
93664ac
Fix: Improve Type Safety in Utility Modules
google-labs-jules[bot] Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: echo ${{ github.event.number }} > ./pr_number

- name: Upload deltas
uses: actions/upload-artifact@v6
uses: actions/upload-artifact@v5
with:
name: delta-action-deltas
retention-days: 7
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Setup Deno
uses: denoland/setup-deno@v1
with:
deno-version: 2.6.6
deno-version: 2.5.6

- name: Install core dependencies
run: npm ci --no-audit
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
run: echo "shard=$(echo '${{ matrix.shard }}' | tr '/' '-')" >> $GITHUB_OUTPUT

- name: Store npm error artefacts
uses: actions/upload-artifact@v6
uses: actions/upload-artifact@v5
if: always()
with:
name: npm-logs--${{ matrix.os }}--${{ matrix.node-version }}--${{ steps.sanitize-shard-name.outputs.shard }}
Expand Down
35 changes: 0 additions & 35 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,41 +8,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).


## [23.14.0](https://github.com/netlify/cli/compare/v23.13.5...v23.14.0) (2026-01-28)


### Features

* ai gateway disabled check ([#7891](https://github.com/netlify/cli/issues/7891)) ([4a57375](https://github.com/netlify/cli/commit/4a57375d570e0f2565a9c9b779ddcb12e1521731))
* **init:** mention detected framework when presenting build settings ([#7828](https://github.com/netlify/cli/issues/7828)) ([f5b3588](https://github.com/netlify/cli/commit/f5b3588cb18c9ed57893f8b16530cc0b4f3b6351))


### Bug Fixes

* address flaky integration tests ([#7890](https://github.com/netlify/cli/issues/7890)) ([a329330](https://github.com/netlify/cli/commit/a329330982b3808baacb16a94e61527787adfe17))
* **deps:** bump tar from 7.5.3 to 7.5.6 ([#7883](https://github.com/netlify/cli/issues/7883)) ([d563fac](https://github.com/netlify/cli/commit/d563fac9d31435f5d5f234f17e75c1342dbf0b63))
* **deps:** update dependency @netlify/edge-functions to v3.0.3 ([#7860](https://github.com/netlify/cli/issues/7860)) ([803c6ae](https://github.com/netlify/cli/commit/803c6ae26e10f957ce4a20ee7ae02786dc6cb947))
* **deps:** update dependency lodash to v4.17.23 [security] ([#7885](https://github.com/netlify/cli/issues/7885)) ([e0fe8dc](https://github.com/netlify/cli/commit/e0fe8dc520e78e0ba0b4eab333c2eff9529f9099))
* **deps:** update netlify packages ([#7895](https://github.com/netlify/cli/issues/7895)) ([63e1eea](https://github.com/netlify/cli/commit/63e1eea463ca86fe4e9f9ea5f4000cdaca2c21fe))
* refactor image handling to use `@netlify/images` ([#7584](https://github.com/netlify/cli/issues/7584)) ([321170d](https://github.com/netlify/cli/commit/321170d8588d9b90459784ebed079e416e13f6c6))

## [23.13.5](https://github.com/netlify/cli/compare/v23.13.4...v23.13.5) (2026-01-20)


### Bug Fixes

* **deps:** bump tar from 7.5.2 to 7.5.3 ([#7871](https://github.com/netlify/cli/issues/7871)) ([3e7c3a0](https://github.com/netlify/cli/commit/3e7c3a0583465815e4941be0f9eafe858159e657))
* **deps:** update netlify packages ([#7873](https://github.com/netlify/cli/issues/7873)) ([be07b3c](https://github.com/netlify/cli/commit/be07b3cc97f82b20bd5492fff1ccb863dd8b44ef))

## [23.13.4](https://github.com/netlify/cli/compare/v23.13.3...v23.13.4) (2026-01-17)


### Bug Fixes

* **deps:** bump h3 from 1.15.4 to 1.15.5 ([#7867](https://github.com/netlify/cli/issues/7867)) ([14eee2c](https://github.com/netlify/cli/commit/14eee2c661f8fe81c4554ed691a486c749ffd2dd))
* **types:** improve type safety in command helpers ([#7852](https://github.com/netlify/cli/issues/7852)) ([665fa01](https://github.com/netlify/cli/commit/665fa010ff3ee40e5eec825019afe62008bf293c))
* **types:** improve type safety in create-stream-promise util ([#7855](https://github.com/netlify/cli/issues/7855)) ([34d8a95](https://github.com/netlify/cli/commit/34d8a9529aca298e37a465b988c4a928746cd562))

## [23.13.3](https://github.com/netlify/cli/compare/v23.13.2...v23.13.3) (2026-01-08)


Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

Interact with [Netlify](http://netlify.com/) from the comfort of your CLI.

See the [CLI command line reference](https://cli.netlify.com/#commands) to get started and the docs on using
See the [CLI command line reference](https://cli.netlify.com/commands/) to get started and the docs on using

Check warning on line 9 in README.md

View workflow job for this annotation

GitHub Actions / lint-docs 

[vale] reported by reviewdog 🐶
[base.accessibilityVision] Don't use vision-based terms. Use something inclusive like 'visit', 'find', or 'check' instead of 'See'.

Raw Output:
{"message": "[base.accessibilityVision] Don't use vision-based terms. Use something inclusive like 'visit', 'find', or 'check' instead of 'See'.", "location": {"path": "README.md", "range": {"start": {"line": 9, "column": 1}}}, "severity": "WARNING"}
[Netlify Dev](https://github.com/netlify/cli/blob/main/docs/commands/dev.md) to run your site locally.

## Table of Contents
Expand Down
2 changes: 1 addition & 1 deletion docs/commands/deploy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ netlify deploy
**Flags**

- `alias` (*string*) - Specifies the alias for deployment, the string at the beginning of the deploy subdomain. Useful for creating predictable deployment URLs. Avoid setting an alias string to the same value as a deployed branch. `alias` doesn’t create a branch deploy and can’t be used in conjunction with the branch subdomain feature. Maximum 37 characters.
- `context` (*string*) - Specify a deploy context for environment variables read during the build ("production", "deploy-preview", "branch-deploy", "dev") or `branch:your-branch` where `your-branch` is the name of a branch (default: dev)
- `context` (*string*) - Specify a deploy context for environment variables read during the build (”production”, ”deploy-preview”, ”branch-deploy”, ”dev”) or `branch:your-branch` where `your-branch` is the name of a branch (default: dev)
- `create-site` (*string*) - Create a new site and deploy to it. Optionally specify a name, otherwise a random name will be generated. Requires --team flag if you have multiple teams.
- `dir` (*string*) - Specify a folder to deploy
- `filter` (*string*) - For monorepos, specify the name of the application to run the command in
Expand Down
11 changes: 5 additions & 6 deletions e2e/install.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,10 @@
]

describe.each(installTests)('%s → installs the cli and runs commands without errors', (packageManager, config) => {
// Yarn v1 enforces engine constraints strictly. A transitive dep (chokidar@5) requires node >=20.19.0,
// breaking yarn installs on older Node 20.x. Node 20 EOL is April 2026, so we skip rather than override.
const yarnOnOldNode20 = packageManager === 'yarn' && process.versions.node === '20.12.2'
// TODO: Figure out why this flow is failing on Windows.
const npxOnWindows = platform() === 'win32' && 'run' in config

itWithMockNpmRegistry.skipIf(yarnOnOldNode20)('runs the commands without errors', async ({ registry }) => {
itWithMockNpmRegistry.skipIf(npxOnWindows)('runs the commands without errors', async ({ registry }) => {
// Install

const cwd = registry.cwd
Expand All @@ -218,7 +217,7 @@
reject: false,
})
if (installResult.exitCode !== 0) {
throw new Error(

Check failure on line 220 in e2e/install.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E (ubuntu-latest, 20.12.2)

e2e/install.e2e.ts > yarn → installs the cli and runs commands without errors > runs the commands without errors 

Error: Install failed for yarn
Exit code: 1

yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
warning netlify-cli > @fastify/static > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > @netlify/zip-it-and-ship-it > @vercel/nft > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > @netlify/zip-it-and-ship-it > archiver > archiver-utils > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > node-fetch > fetch-blob > node-domexception@1.0.0: Use your platform's native DOMException instead
[2/4] Fetching packages...
error chokidar@5.0.0: The engine "node" is incompatible with this module. Expected version ">= 20.19.0". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
 ❯ e2e/install.e2e.ts:220:13

Check failure on line 220 in e2e/install.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E (macOS-latest, 20.12.2)

e2e/install.e2e.ts > yarn → installs the cli and runs commands without errors > runs the commands without errors 

Error: Install failed for yarn
Exit code: 1

yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
warning netlify-cli > @fastify/static > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > @netlify/zip-it-and-ship-it > @vercel/nft > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > @netlify/zip-it-and-ship-it > archiver > archiver-utils > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > node-fetch > fetch-blob > node-domexception@1.0.0: Use your platform's native DOMException instead
[2/4] Fetching packages...
error chokidar@5.0.0: The engine "node" is incompatible with this module. Expected version ">= 20.19.0". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
 ❯ e2e/install.e2e.ts:220:13

Check failure on line 220 in e2e/install.e2e.ts

View workflow job for this annotation

GitHub Actions / E2E Windows tests (windows-2025, 20.12.2)

e2e/install.e2e.ts > yarn → installs the cli and runs commands without errors > runs the commands without errors 

Error: Install failed for yarn
Exit code: 1

Corepack is about to download https://registry.yarnpkg.com/yarn/-/yarn-1.22.22.tgz.
yarn add v1.22.22
info No lockfile found.
[1/4] Resolving packages...
warning netlify-cli > @fastify/static > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > @netlify/zip-it-and-ship-it > @vercel/nft > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > @netlify/zip-it-and-ship-it > archiver > archiver-utils > glob@10.5.0: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
warning netlify-cli > node-fetch > fetch-blob > node-domexception@1.0.0: Use your platform's native DOMException instead
[2/4] Fetching packages...
error chokidar@5.0.0: The engine "node" is incompatible with this module. Expected version ">= 20.19.0". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
 ❯ e2e/install.e2e.ts:220:13
`Install failed for ${packageManager}\nExit code: ${installResult.exitCode.toString()}\n\n${
installResult.all || ''
}`,
Expand Down Expand Up @@ -304,9 +303,9 @@

describe.each(runTests)('%s → runs cli commands without errors', (packageManager, config) => {
// TODO: Figure out why this flow is failing on Windows.
const skipOnWindows = platform() === 'win32'
const npxOnWindows = platform() === 'win32' && 'run' in config

itWithMockNpmRegistry.skipIf(skipOnWindows)('runs commands without errors', async ({ registry }) => {
itWithMockNpmRegistry.skipIf(npxOnWindows)('runs commands without errors', async ({ registry }) => {
const [cmd, args] = config.run
const env = {
npm_config_registry: registry.address,
Expand Down
Loading
Loading