Add VRF field support for all IPAM resource types#515
Open
richir-sunet wants to merge 1 commit intonetbox-community:mainfrom
Open
Add VRF field support for all IPAM resource types#515richir-sunet wants to merge 1 commit intonetbox-community:mainfrom
richir-sunet wants to merge 1 commit intonetbox-community:mainfrom
Conversation
Collaborator
|
Hi @richir-sunet, thanks for opening this PR. The code looks good. I'm not sure about adding the vrf to the hash, other immutable fields were added to the hash but this does not allow for changes in those fields later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't see any progress on #400 so I asked Claude to help me get it done. Not sure what your view is on AI code, but I didn't write any of this myself. What I did do was run e2e tests (
tests/e2e/READMEfelt a bit outdated though?), and they all passed. I also applied theconfig/samples/in a local kind setup and that seems to have worked as intended as far as I can tell.