feat(microservices): add return buffers option for binary data#16676
Open
Forceres wants to merge 2 commits intonestjs:masterfrom
Open
feat(microservices): add return buffers option for binary data#16676Forceres wants to merge 2 commits intonestjs:masterfrom
Forceres wants to merge 2 commits intonestjs:masterfrom
Conversation
Pull Request Test Coverage Report for Build 472dd428-2ae6-4d12-bfd5-a48cbbd1c630Details
💛 - Coveralls |
Member
|
Could you please add an integration test for this as well? |
Author
Yeah, give me some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Now we can't directly get buffers from redis, so any custom binary formats are broken. Moreover, our redis output has to be json that contradicts to custom binary formats.
What is the new behavior?
We can pass returnBuffers to client options for listening on "messageBuffer" instead of "message" to get directly buffers from redis. createResponseCallback handles jsons as well as binary (but we have to pass custom deserializer to decode id from it)
Does this PR introduce a breaking change?