Skip to content

Fix ingest-claude-code path decoding and deduplicate constants#330

Merged
neongreen merged 3 commits intoemily/jj-qmpypprwrrtlfrom
copilot/sub-pr-329
Nov 30, 2025
Merged

Fix ingest-claude-code path decoding and deduplicate constants#330
neongreen merged 3 commits intoemily/jj-qmpypprwrrtlfrom
copilot/sub-pr-329

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 30, 2025

Addresses review feedback on ingest-claude-code tool and add-go-project skill documentation.

Fixes

  • Path decoding: Fixed project path conversion that incorrectly replaced all hyphens with slashes. Now properly handles the Claude trace format (e.g., -Users-artyom-code-neongreen-mono) by removing only the leading hyphen and using filepath.Join() for cross-platform compatibility.

  • Constant deduplication: Extracted maxScannerCapacity (10MB buffer for large trace lines) to shared constants.go.

  • Documentation clarity: Clarified in SKILL.md that new projects must use full module paths (e.g., github.com/neongreen/mono/my-tool), noting existing short names are historical.

  • Integration: Added ingest-claude-code to go-projects.toml.

Path decoding change

// Before: breaks "my-project" → "my/project"
session.ProjectPath = strings.ReplaceAll(dirName, "-", "/")

// After: handles "-Users-artyom-code-mono" → "Users/artyom/code/mono"
if strings.HasPrefix(decoded, "-") {
    decoded = decoded[1:]
}
segments := strings.Split(decoded, "-")
session.ProjectPath = filepath.Join(segments...)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits November 30, 2025 08:50
Co-authored-by: neongreen <1523306+neongreen@users.noreply.github.com>
Co-authored-by: neongreen <1523306+neongreen@users.noreply.github.com>
Copilot AI changed the title [WIP] Add ingest-claude-code tool and skills documentation Fix ingest-claude-code path decoding and deduplicate constants Nov 30, 2025
Copilot AI requested a review from neongreen November 30, 2025 08:54
@neongreen neongreen marked this pull request as ready for review November 30, 2025 09:01
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@neongreen neongreen merged commit 900595e into emily/jj-qmpypprwrrtl Nov 30, 2025
0 of 4 checks passed
@neongreen neongreen deleted the copilot/sub-pr-329 branch November 30, 2025 09:06
@mergify
Copy link
Copy Markdown

mergify bot commented Nov 30, 2025

🧪 CI Insights

Here's what we observed from your CI run for b5167e0.

🟢 All jobs passed!

But CI Insights is watching 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants