Skip to content

Add consolidated tk events documentation#323

Merged
neongreen merged 3 commits intomainfrom
codex/add-support-for-processing-nested-comments
Nov 26, 2025
Merged

Add consolidated tk events documentation#323
neongreen merged 3 commits intomainfrom
codex/add-support-for-processing-nested-comments

Conversation

@neongreen
Copy link
Copy Markdown
Owner

Summary

  • add lion markers to funnel all tk events into a consolidated events topic
  • regenerate documentation, producing events.md with per-event sections and updating existing event pages and index

Testing

  • go run ./lion generate ./tk --output ./tk/docs

Codex Task

@mergify
Copy link
Copy Markdown

mergify Bot commented Nov 23, 2025

🧪 CI Insights

Here's what we observed from your CI run for a61d772.

🟢 All jobs passed!

But CI Insights is watching 👀

@neongreen neongreen marked this pull request as ready for review November 23, 2025 22:24
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +190 to +192
if len(entries) != 3 {
t.Fatalf("expected 3 entries, got %d", len(entries))
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Correct expected inline doc entry count

Go groups adjacent line comments into a single ast.CommentGroup, and extractFromFile processes one DocEntry per comment group/topic (see extractor.go lines 111-121, 276-295). In the inline sample the first two //lion:inline-semantics lines are contiguous, so the extractor will yield two entries, not three. The new assertion expecting len(entries) == 3 therefore fails every run.

Useful? React with 👍 / 👎.

@neongreen neongreen merged commit 189f053 into main Nov 26, 2025
4 of 6 checks passed
@neongreen neongreen deleted the codex/add-support-for-processing-nested-comments branch November 26, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant