Conversation
This commit introduces a newtype pattern in Go to prevent bugs related to project reference resolution. Previously, projects could be referenced by UID, alias, or name, but these were all handled as strings, leading to inconsistent behavior and potential bugs. Changes: - Add ProjectRef type for unresolved project references (UID, alias, or name) - Add ResolveProjectRef() function that takes ProjectRef and returns ProjectUID - Update preferredAliasForProject() to take ProjectUID instead of string - Fix project alias add command to resolve any project reference - Fix project rm command to use standard resolution logic - Fix task creation to display friendly alias instead of raw UID - Update all call sites to use strongly-typed functions This follows the Haskell-style newtype pattern to make invalid states unrepresentable at compile time. Functions that need a resolved ProjectUID now explicitly take that type, while functions that accept user input take ProjectRef and resolve internally.
🧪 CI InsightsHere's what we observed from your CI run for 02c7656. 🟢 All jobs passed!But CI Insights is watching 👀 |
neongreen
deleted the
claude/audit-project-reference-bugs-011CUi3dGcwTfs78Z1Ggio9i
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a newtype pattern in Go to prevent bugs related to project reference resolution. Previously, projects could be referenced by UID, alias, or name, but these were all handled as strings, leading to inconsistent behavior and potential bugs.
Changes:
This follows the Haskell-style newtype pattern to make invalid states unrepresentable at compile time. Functions that need a resolved ProjectUID now explicitly take that type, while functions that accept user input take ProjectRef and resolve internally.