Skip to content

Remove confirmation prompt from tk-vscode builds in want mono#227

Merged
neongreen merged 3 commits intomainfrom
copilot/remove-confirmation-for-mono-tk-vscode
Nov 2, 2025
Merged

Remove confirmation prompt from tk-vscode builds in want mono#227
neongreen merged 3 commits intomainfrom
copilot/remove-confirmation-for-mono-tk-vscode

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 1, 2025

  • Understand the issue: tk-vscode builds ask for confirmation, but other "want mono" builds don't
  • Remove ConfirmPlan() calls from buildVSCodeExtensionFromSource in vscode.go
  • Remove ConfirmPlan() calls from buildVSCodeExtensionFromPR in vscode.go
  • Test the changes to ensure they work correctly
  • Run go fmt to format the code
  • Rebased onto main to fix test failures (tests were failing due to outdated base commit)
Original prompt

in "want mono tk-vscode...", please also don't ask for confirmation (like in other "want mono" cases)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove confirmation prompt for mono tk-vscode Remove confirmation prompt from tk-vscode builds in want mono Nov 1, 2025
Copilot AI requested a review from neongreen November 1, 2025 23:45
@neongreen neongreen marked this pull request as ready for review November 1, 2025 23:47
@mergify
Copy link
Copy Markdown

mergify Bot commented Nov 1, 2025

🧪 CI Insights

Here's what we observed from your CI run for 0f1413c.

🟢 All jobs passed!

But CI Insights is watching 👀

@neongreen
Copy link
Copy Markdown
Owner

@copilot why are the tests failing?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Nov 1, 2025

@copilot why are the tests failing?

The tests were failing because the branch was based on an outdated commit (75b8df0) from before the Dagger test workflow was properly set up. I rebased the branch onto current main (commit 73b8938) to fix this.

The tests now pass locally. However, the rebased branch needs to be force-pushed to update the PR. The local branch is ready at commit a79e715.

The actual code changes remain the same - just removed the ConfirmPlan() calls from two functions in want/vscode.go.

@neongreen neongreen merged commit 71494ef into main Nov 2, 2025
1 of 4 checks passed
@neongreen neongreen deleted the copilot/remove-confirmation-for-mono-tk-vscode branch November 2, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants