Disable pull_request triggers in all workflows#220
Conversation
Only run workflows on push events, not on pull requests. This affects: - diagram-dsl-lint.yml - diagram-dsl.yml - go-module-lint.yml - dagger-tests.yml - mdbook-comments.yml
🧪 CI InsightsHere's what we observed from your CI run for 326e1f5. 🟢 All jobs passed!But CI Insights is watching 👀 |
neongreen
deleted the
claude/disable-pull-workflows-011CUhwaZ4czXkLSDxpjcnjp
branch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
mono/.github/workflows/dagger-tests.yml
Lines 1 to 17 in 326e1f5
Restore PR triggers so workflows run for fork contributions
Removing the pull_request trigger means this workflow now only runs on push. That works for branches inside this repo, but it never fires for pull requests coming from forks because their pushes happen in a different repository. As a result the Dagger tests (and the other workflows modified in this commit) will not execute for external contributors, leaving those PRs untested unless a maintainer runs them manually. If forked PRs are expected, the pull_request trigger (or pull_request_target) needs to stay.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
No description provided.