Add support for deleting issues and projects in tk-vsc#217
Conversation
… filters - Add project.delete event type and ProjectDeletePayload - Implement "tk project rm" command to delete projects - Rename "tk delete" to "tk rm" with aliases (delete, del, remove) - Add deleteTask and deleteProject commands to tk-vsc - Remove all success toasts from tk-vsc (only warnings/errors) - Add status filter buttons (next, wip, done, none) to tk-vsc - Document no-success-toast rule in tk-vscode/AGENTS.md Co-authored-by: neongreen <1523306+neongreen@users.noreply.github.com>
- Add taskProjects map to reducer to track task-project associations - Update applyTaskCreated to store project associations - Implement applyProjectDelete to delete all tasks in a project - Update applyTaskDelete to clean up project associations - Update ProjectProjectDeleteEvent to delete tasks from database tables Now when a project is deleted, all tasks in that project are properly removed from both the database and the reducer's in-memory state. Co-authored-by: neongreen <1523306+neongreen@users.noreply.github.com>
Co-authored-by: neongreen <1523306+neongreen@users.noreply.github.com>
|
@copilot continue |
All features have been implemented and tested successfully:
All tests pass and the implementation has been verified with manual testing. |
🧪 CI InsightsHere's what we observed from your CI run for d3e2bf3. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
💡 Codex Review
mono/tk/internal/reducer/reducer.go
Lines 474 to 482 in d3e2bf3
The reducer now maintains taskProjects and relies on it when handling project.delete to remove all tasks in the deleted project. However applyTaskRelocate still ignores relocation events and never updates that map. Any task that was created in project A and later moved to project B will remain mapped to A, so deleting project B will leave those tasks in memory (and they will still be shown by tk ls), while deleting project A will remove tasks that no longer belong to it. The project delete event therefore cannot reliably remove the correct tasks until the relocation handler updates taskProjects for the new project.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
All features implemented, tested, and refactored based on code review suggestions.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.