Skip to content

CherryPick(#4512 for N4): add delegate for creating spcific LoggerConfiguration#4527

Merged
shargon merged 1 commit intoneo-project:masterfrom
Wi1l-B0t:optimize.n4.LogFactory
Apr 12, 2026
Merged

CherryPick(#4512 for N4): add delegate for creating spcific LoggerConfiguration#4527
shargon merged 1 commit intoneo-project:masterfrom
Wi1l-B0t:optimize.n4.LogFactory

Conversation

@Wi1l-B0t
Copy link
Copy Markdown
Contributor

@Wi1l-B0t Wi1l-B0t commented Apr 9, 2026

Cherry pick #4487 #4513 for N4.

Add delegate for creating specific LoggerConfiguration.
Different configurations in different scenarios(for example: different sinks).

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing
  • Run Application
  • Local Computer Tests
  • No Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the N4 label Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 64.10256% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.44%. Comparing base (e3808bf) to head (18658d8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Neo/Plugins/Plugin.cs 30.00% 7 Missing ⚠️
src/Neo.Extensions/Logs.cs 76.92% 5 Missing and 1 partial ⚠️
src/Neo/NeoSystem.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4527      +/-   ##
==========================================
- Coverage   74.45%   74.44%   -0.01%     
==========================================
  Files         239      239              
  Lines       16193    16188       -5     
  Branches     2388     2386       -2     
==========================================
- Hits        12056    12051       -5     
- Misses       3417     3418       +1     
+ Partials      720      719       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shargon shargon merged commit dba502a into neo-project:master Apr 12, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants