Make lyric lines accessible (#32514 & 19510) [4.7.1]

[mathesoncalum]

Resolves: #32514
Resolves: #19510

This PR includes lyric lines in the alt+direction navigation chain (ace2e5d) and ensures that the screen reader reads the type name out (0b6c55a). The video below demos the navigation order, which is as follows when starting on a note:

1st verse lyrics -> 1st verse lyrics line -> 2nd verse lyrics -> 2nd verse lyrics line (etc.) -> next note

lyrlinedemo.mov

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[mathesoncalum]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 89f90c13-e128-486b-a3e0-c2128843aac9

📥 Commits

Reviewing files that changed from the base of the PR and between 28f5d2a and 0b6c55a.

📒 Files selected for processing (2)

• src/engraving/dom/chordrest.cpp
• src/engraving/rendering/score/lyricslayout.cpp

---

📝 Walkthrough

Walkthrough

ChordRest navigation between articulations and lyrics is refactored to explicitly handle LyricsLine elements. The nextArticulationOrLyric and prevArticulationOrLyric methods now detect LyricsLine objects, return their associated Lyrics, and correct cycling behavior to return nullptr consistently. Element dispatch in nextElement and prevElement is updated to route ElementType::LYRICSLINE through the same articulation/lyric navigation path as ElementType::LYRICS. The lastElementBeforeSegment method now prefers returning LyricsLine separators when present. Additionally, LyricsLayout::createOrRemoveLyricsLine switches from direct allocation to Factory::createLyricsLine for object construction.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 55.56% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: making lyric lines accessible via navigation. It references the linked issues and version.
Description check	✅ Passed	The description includes issue references, clear explanation of changes, a demonstration of the navigation order, and a video demo. However, it lacks completion of the template checklist items.
Linked Issues check	✅ Passed	The code changes implement the core requirements: making lyric lines navigable via Alt+arrow navigation [#32514] and ensuring screen readers announce lyric-line type information [#19510].
Out of Scope Changes check	✅ Passed	All changes are directly related to making lyric lines navigable and accessible: updates to navigation logic in ChordRest and lyric line creation in LyricsLayout.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}