Fix Braille interval direction

[fcnjd]

Resolves: #23953

This changes the following:

• interval direction is now correctly applied
• applying the change immediately triggers a reload of the live Braille panel
• For clef determination in the live Braille panel, the beginning of the part is now considered instead of the current bar. Directions aren't supposed to change within a system.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[fcnjd]

I know that I'm behind latest main, but #33424 is blocking me from building, so I'm at an earlier stage. Once that's resolved, I'm happy to merge.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 40f933ac-faac-4c54-b312-b9da5271ab5e

📥 Commits

Reviewing files that changed from the base of the PR and between d578d25 and 701bc84.

📒 Files selected for processing (6)

• src/braille/internal/braille.cpp
• src/braille/internal/braille.h
• src/braille/internal/brailleconverter.cpp
• src/braille/internal/braillewriter.cpp
• src/braille/internal/notationbraille.cpp
• src/braille/tests/braille_tests.cpp

---

📝 Walkthrough

Walkthrough

This pull request adds a BrailleIntervalDirection parameter to the Braille class constructor to enable explicit control over chord interval direction rendering. The constructor now accepts and stores this parameter. In ascendingChords(), when the interval direction is set to Up or Down, a fixed direction is returned; when set to Auto, the existing clef-based logic is used. The brailleChord() method now derives the clef directly from Score instead of using m_context. The parameter is threaded through all Braille construction sites: converters and writers use Auto, while NotationBraille constructs instances with the user's configured preference and refreshes braille output on preference changes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: fixing the Braille interval direction feature to work correctly.
Description check	✅ Passed	The description provides clear changes, references issue #23953, and completes the required checklist. Minor note: unit test not provided, but checkbox indicates this is optional.
Linked Issues check	✅ Passed	The PR implementation directly addresses all coding requirements from issue #23953: accepts interval direction parameter, stores and applies it, triggers reload on preference changes, and uses first part clef instead of current bar.
Out of Scope Changes check	✅ Passed	All changes directly support fixing the Braille interval direction feature. No unrelated modifications detected in the file summaries.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}