Skip to content

fixed #33401: Fixed random crashes #33423

Open
Eism wants to merge 1 commit into
musescore:4.7from
Eism:win_ssl_crash_fix_4.7
Open

fixed #33401: Fixed random crashes #33423
Eism wants to merge 1 commit into
musescore:4.7from
Eism:win_ssl_crash_fix_4.7

Conversation

@Eism
Copy link
Copy Markdown
Contributor

@Eism Eism commented May 15, 2026

Resolves: #33401

Qt prefers OpenSSL when qopensslbackend.dll is present, which can crash on ABI mismatch with bundled OpenSSL, The Windows installer installs only schannel, but Qt might find qopensslbackend.dll in the system.

@Eism Eism requested a review from RomanPudashkin May 15, 2026 09:29
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@Eism Eism changed the title fixed #33401: Force schannel backend fixed #33401: Fixed random crashes May 15, 2026
@Eism Eism force-pushed the win_ssl_crash_fix_4.7 branch 2 times, most recently from fb12ab2 to a8f2f6a Compare May 15, 2026 09:34
@cbjeukendrup
Copy link
Copy Markdown
Collaborator

Or should we adjust the packaging code to always bundle the correct OpenSSL binaries, so that that one is used instead of one from the system? (I don't know what the advantage of OpenSSL is, but I'd assume there is some, since Qt appears to prefer it)

@RomanPudashkin RomanPudashkin linked an issue May 15, 2026 that may be closed by this pull request
4 tasks
@shoogle shoogle mentioned this pull request May 16, 2026
4 tasks
@Eism Eism force-pushed the win_ssl_crash_fix_4.7 branch from a8f2f6a to d32e7ab Compare May 18, 2026 07:27
@Eism
Copy link
Copy Markdown
Contributor Author

Eism commented May 18, 2026

@cbjeukendrup Good question!

OpenSSL has been around for a long time, and everyone uses it. But native SChannel wrappers for Windows and SecureTransport for Mac have appeared. Meanwhile, OpenSSL is still around, and Qt uses it first when searching for a backend.
After some time, we stopped installing OpenSSL when deploy (I really don't know when we stopped doing it, I didn't find the right commit), and overall, it seems like it's not really needed given MuseScore's needs. I mean, all our requests should work with SChannel as well. OpenSSL provides low-level TLS features for specialized applications. MuseScore makes HTTPS requests to musescore.com, MuseHub, and updates. This is a completely trivial task for any TLS stack. OpenSSL offers no advantage here.

Btw, OpenSSL doesn't copy to macOS either.

Maybe we should disable OpenSSL and see if that solves the problems for users?
@igorkorsukov @RomanPudashkin what do you think?

@igorkorsukov
Copy link
Copy Markdown
Contributor

I think we should make it as simple as possible; it's really not important to us.

As I understand it, Qt favors OpenSSL for compatibility because it's been around for so long (and probably because it's Open).

Qt prefers OpenSSL when qopensslbackend.dll is present, which can crash on ABI mismatch with bundled OpenSSL, but installer use only schannel, So let's use schannel
@RomanPudashkin RomanPudashkin force-pushed the win_ssl_crash_fix_4.7 branch from d32e7ab to 8e62d89 Compare May 18, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random Crashes in 4.7

4 participants