Refactor packet types

[hulthe]

This change is 

[MarkusPettersson98]

@MarkusPettersson98 made 1 comment.
Reviewable status: 0 of 14 files reviewed, 6 unresolved discussions (waiting on dlon and hulthe).

---

gotatun/Cargo.toml line 4 at r5 (raw file):

name = "gotatun"
description = "an implementation of the WireGuard® protocol designed for portability and speed"
version = "0.7.0"

Don't forget to write about this change in the changelog!

Code quote:

version = "0.7.0"

[hulthe]

@hulthe reviewed 17 files and all commit messages, made 5 comments, resolved 5 discussions, and dismissed @dlon from 4 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dlon and hulthe).

---

gotatun/Cargo.toml line 4 at r5 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Don't forget to write about this change in the changelog!

Done

---

gotatun/src/packet/udp.rs line 76 at r2 (raw file):

pub struct UdpDecoder {
    pub length: bool,
    pub checksum: bool, // TODO: should this be here?

todo

[hulthe]

@hulthe reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dlon and MarkusPettersson98).

[dlon]

@dlon reviewed 15 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on hulthe and MarkusPettersson98).

---

gotatun/src/packet/mod.rs line 492 at r9 (raw file):

}

fn validate_tcp(next_protocol: IpNextProtocol, payload: &[u8]) -> eyre::Result<()> {

Could be replaced with a TcpDecoder, I guess?

---

gotatun/src/packet/tcp.rs line 288 at r9 (raw file):

    use zerocopy::TryFromBytes;

    const EXAMPLE_IPV4_TCP: &[u8] = &[

Should we add checksum tests?