feature gate native socket implementation#125
Open
SocraticSauropod wants to merge 1 commit intomullvad:mainfrom
Open
feature gate native socket implementation#125SocraticSauropod wants to merge 1 commit intomullvad:mainfrom
SocraticSauropod wants to merge 1 commit intomullvad:mainfrom
Conversation
As part of this, we also feature gate some things which the sockets implementation depends on, which are not depended on by the whole codebase. In particular, the `socket2` crate, and `tokio`'s `"net"` feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #121.
As part of this, we also feature gate some things which the sockets implementation depends on, which are not depended on by the whole codebase. In particular, the
socket2crate, andtokio's"net"feature.Open question: What actually should the feature be named?
I find myself a little partial to
native_sockets, though this currently names itsocket.This change is