Fxp 3678 update browsers on awfy

[kala-moz]

This PR will replace Update browsers fix #530
Closes Jira issue Update browsers on AWFY FXP 3678

Note: For this review, I need help with test/config.test.js li14 test

[netlify]

✅ Deploy Preview for firefox-performance-dashboard ready!

Name	Link
🔨 Latest commit	75963d7
🔍 Latest deploy log	https://app.netlify.com/sites/firefox-performance-dashboard/deploys/675a452e8b73a900085ac03b
😎 Deploy Preview	https://deploy-preview-532--firefox-performance-dashboard.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[92kns]

thanks @Carla-Moz ! just some quick questions before i take a deeper look
curious what were the reason(s) for modifying the yarn.lock file (was it related to the security stuff? if so I think that is outside the scope of this PR and should be done separately)

also curious how were the har files created/updated? that never happened for me (unless it was related to the yarn.lock changes, then nvm)

[kala-moz]

thanks @Carla-Moz ! just some quick questions before i take a deeper look curious what were the reason(s) for modifying the yarn.lock file (was it related to the security stuff? if so I think that is outside the scope of this PR and should be done separately)

also curious how were the har files created/updated? that never happened for me (unless it was related to the yarn.lock changes, then nvm)

Actually, I didn't mean to include yarn.lock in the commit. Let me revert and see if that fixes things.

[kala-moz]

@92kns And yes, I plan to fix the security concerns in a separate PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (630500e) to head (5b29ef8).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   85.42%   86.00%   +0.57%     
==========================================
  Files          14       14              
  Lines         350      350              
  Branches       52       51       -1     
==========================================
+ Hits          299      301       +2     
+ Misses         46       44       -2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[92kns]

I am not too familiar with this - what is/was the reason to do this?

[kala-moz]

Like I said in our previous, I was force updating the snapshots but I'll remove this because this should only be done locally.

[92kns]

also, could you please squash the commits? might be easiest to squash to 1-3 commits (up to you) and force push

[92kns]

@Carla-Moz Revisiting the old ticket looks like we had this requirement I forgot to bring up again from https://bugzilla.mozilla.org/show_bug.cgi?id=1910645#c1

"We should also add a link to an FAQ (perhaps in the GitHub README) from the top of the page, and include a brief explainer of what we're showing. Something like "Using the most recent build available to us of the relevant browsers" and also touch on how/why we're building Chromium as release."

could you look into adding something like that?

[kala-moz]

@Carla-Moz Revisiting the old ticket looks like we had this requirement I forgot to bring up again from https://bugzilla.mozilla.org/show_bug.cgi?id=1910645#c1

"We should also add a link to an FAQ (perhaps in the GitHub README) from the top of the page, and include a brief explainer of what we're showing. Something like "Using the most recent build available to us of the relevant browsers" and also touch on how/why we're building Chromium as release."

could you look into adding something like that?

Sure! First, do we already have the link to the FAQ? Second, I would need the answer to this question: how and why are we building Chromium as release?

[92kns]

@Carla-Moz Revisiting the old ticket looks like we had this requirement I forgot to bring up again from https://bugzilla.mozilla.org/show_bug.cgi?id=1910645#c1
"We should also add a link to an FAQ (perhaps in the GitHub README) from the top of the page, and include a brief explainer of what we're showing. Something like "Using the most recent build available to us of the relevant browsers" and also touch on how/why we're building Chromium as release."
could you look into adding something like that?

Sure! First, do we already have the link to the FAQ? Second, I would need the answer to this question: how and why are we building Chromium as release?

sorry for the delay, finally following up from Element :)

do we already have the link to the FAQ?

No we don't have a FAQ. For now it might be easiest to just add an FAQ section to the README and we can slowly build on that over time. And if possible, a link to the FAQ section of the README in the AWFY landing page (somewhere in the top?) would be useful.

Second, I would need the answer to this question: how and why are we building Chromium as release?

We build a (custom) Chromium-as-Release (also referred to as CaR or custom-car as well) to give us insight into the latest upstream performance improvements done by the chromium developers. Contrast this to regular chrome release (a.k.a chrome stable) which is only updated every ~4 weeks, and the Chrome nightly (e.g. the "canary" channel) is updated only twice a day I believe. Previously we've found that Canary was configured in a way that wasn't too useful for us. But with our custom Chromium-as-Release builds, we have a bit more control in the configuration and the data seems to have been reliable so far