Some bugs

app/src/main/java/fr/inria/verveine/extractor/java/visitors/refvisitors/VisitorExceptionRef.java

@@ -77,15 +77,33 @@ public void endVisit(MethodDeclaration node) {
 	}
 
     @Override
+    /**
+     * Must create a FamixJavaThrownException relation and thus must find the appropriate FamixJavaException type
+     * 
+     * There is a difficulty with UnionType:
+     * <code>catch (SAXException | IOException e) { throw e; }</code>
+     * where JDT reports java.lang.object for the type of the exception thrown !?!?!<BR>
+     * There are also other cases where the type is unknown. <BR>
+     * In these case, we force <code>java.lang.Throwable</code>
+     */
     public boolean visit(ThrowStatement node) {
+    	TType thrownExceptionType = null;
+    	TThrowable excepFmx = null;
+    	ITypeBinding exceptTypeBnd = null;
+
         Method meth = (Method) this.context.topMethod();
-        TType thrownExceptionType = this.referredType(node.getExpression().resolveTypeBinding(), (TNamedEntity) context.topType(), true);
-        TThrowable excepFmx;
+
+        exceptTypeBnd = node.getExpression().resolveTypeBinding();
+        if ( (exceptTypeBnd != null) && (! exceptTypeBnd.getQualifiedName().equals("java.lang.Object")) ) {
+        	thrownExceptionType = this.referredType(exceptTypeBnd, (TNamedEntity) context.topType(), true);
+        }
+
         if (thrownExceptionType == null) {
             excepFmx = dico.ensureFamixException(null, "Throwable", null, false, EntityDictionary.UNKNOWN_MODIFIERS) ;
         }
         else {
-        excepFmx = dico.asException( thrownExceptionType);}
+        	excepFmx = dico.asException( thrownExceptionType);
+        }
         if (excepFmx != null) {
         	dico.createFamixThrownException(meth, excepFmx);
         }
@@ -98,6 +116,9 @@ public boolean visit(ThrowStatement node) {
  	 *	The FormalParameter is represented by a SingleVariableDeclaration
  	 *
  	 * We set the type of the catchClause variable here because it would be more difficult in VisitorTypeRefRef
+ 	 * <p>
+ 	 * TODO handle UnionType such as in <code>catch (SAXException|IOException e)</code>
+ 	 * see {@linkplain https://github.com/moosetechnology/VerveineJ/issues/185 }
      */
     @Override
     public boolean visit(CatchClause node) {

app/src/test/java/fr/inria/verveine/extractor/java/VerveineJTest_AdHoc.java

@@ -927,8 +927,8 @@ public void testOwnerOfObjectIsNotAlwaysJavaLang() {
     @Test
     /*
     * Issue: https://github.com/moosetechnology/VerveineJ/issues/180
-    * Regression test ensuring that a class named Object does not always have "java.lang" as owner
-     */
+    * Call of a (String) method directly on a BlockText
+    */
     public void testInvocationReceiverCanBeATextBlock() {
         parse(new String[]{"src/test/resources/ad_hoc/TextBlocks.java"});
 

app/src/test/java/fr/inria/verveine/extractor/java/VerveineJTest_Exceptions.java

@@ -9,6 +9,8 @@
 
 import static org.junit.Assert.*;
 
+import org.eclipse.jdt.core.dom.ThrowStatement;
+
 public class VerveineJTest_Exceptions extends VerveineJTest_Basic {
 
     /**
@@ -147,4 +149,19 @@ public void testStubExpressionInThrow() {
         assertEquals( "Throwable", ((org.moosetechnology.model.famix.famixjavaentities.Exception)inferredException).getName());
     }
 
+    @Test
+    /*
+     * Not really testing the intended special case in <code>VisitorExceptionRef.visit(ThrowStatement)</code>
+     * because cannot get <code>node.getExpression().resolveTypeBinding()</code> to return <code>Object</code>
+     * But at least, it is testing a case with <code>UnionType</code>
+     */
+    public void testThrowingUnionTypeException() {
+        org.moosetechnology.model.famix.famixjavaentities.Method throwerMethod = detectFamixElement(org.moosetechnology.model.famix.famixjavaentities.Method.class , "unionTypeThrower");
+
+        assertNotNull(throwerMethod);
+
+        assertEquals(1,throwerMethod.getThrownExceptions().size());
+        assertEquals("Throwable", ((TNamedEntity)firstElt(throwerMethod.getThrownExceptions())).getName() );
+    }
+
 }

app/src/test/resources/exceptions/CatchUnionException.java

@@ -0,0 +1,16 @@
+
+package exceptions;
+
+import java.io.IOError;
+import org.xml.sax.SAXException;
+
+class CatchUnionException {
+	public void unionTypeThrower() {
+		try {
+			// nothing
+		}
+		catch (SAXException | IOError e) {
+			throw e;
+		}
+	}
+}