feat(input): DualSense firmware passthrough, player LED and mic LED forwarding#1854
Open
hkirste wants to merge 1 commit into
Open
feat(input): DualSense firmware passthrough, player LED and mic LED forwarding#1854hkirste wants to merge 1 commit into
hkirste wants to merge 1 commit into
Conversation
When a DualSense (PS5) controller connects, read the raw HID firmware report (feature report 0x20) from the physical controller and send it to the host as a TLV metadata extension on the controller arrival event. This allows the host to configure the virtual DualSense with the real controller's firmware version, preventing firmware update prompts and improving compatibility with applications that inspect firmware data. On Windows, uses the native HID API (CreateFile + HidD_GetFeature) with shared access since SDL's game controller backend holds the device exclusively and SDL_hid_open cannot obtain a second handle. Gracefully skips if the HID device can't be opened or the feature report read fails. Requires SDL 2.0.18+ for SDL_hid_enumerate. Bumps moonlight-common-c submodule for TLV metadata protocol extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three DualSense streaming enhancements:
Firmware version passthrough:
Player LED forwarding (protocol 0x5504):
SDL_GameControllerSendEffectMic LED forwarding (protocol 0x5505):
All features are PS5-only (
SDL_CONTROLLER_TYPE_PS5check) and require SDL 2.0.16+. Firmware read requires SDL 2.0.18+ and is Windows-only (#ifdef _WIN32).Dependencies
Test plan
Jul 4 2025successfully passed through to virtual DualSense on host