Skip to content

🐛 Vsphere idle connections fix #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AdamVB wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

🐛 Vsphere idle connections fix #6583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80429ae
fix idle connections
AdamVB Feb 6, 2026
55fc754
fix idle connections
AdamVB Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions providers/vsphere/connection/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,9 @@ func (c *VsphereConnection) Asset() *inventory.Asset {
func (c *VsphereConnection) Client() *govmomi.Client {
return c.client
}

func (c *VsphereConnection) Close() {
if c.client != nil {
c.client.Logout(context.Background())
Copy link
Copy Markdown

@mondoo-code-review mondoo-code-review bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 suggestion — Logout returns an error that is silently discarded. Consider logging it so failed logouts are visible in debug output:

if err := c.client.Logout(context.Background()); err != nil {
	log.Debug().Err(err).Msg("failed to logout vsphere session")
}

Not a correctness issue (the Closer interface is Close() with no return), but helpful for diagnosing connection-cleanup failures.

}
}
4 changes: 2 additions & 2 deletions providers/vsphere/resources/discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func discoverDatacenter(conn *connection.VsphereConnection, datacenterResource *
}

platformID := connection.VsphereResourceID(instanceUuid, mqlHost.Moid.Data)
clonedConfig := conn.Conf.Clone(inventory.WithoutDiscovery())
clonedConfig := conn.Conf.Clone(inventory.WithoutDiscovery(), inventory.WithParentConnectionId(conn.Conf.Id))
clonedConfig.PlatformId = platformID

labels := map[string]string{
Expand Down Expand Up @@ -167,7 +167,7 @@ func discoverDatacenter(conn *connection.VsphereConnection, datacenterResource *
vm := vmList.Data[j].(*mqlVsphereVm)

platformID := connection.VsphereResourceID(instanceUuid, vm.Moid.Data)
clonedConfig := conn.Conf.Clone(inventory.WithoutDiscovery())
clonedConfig := conn.Conf.Clone(inventory.WithoutDiscovery(), inventory.WithParentConnectionId(conn.Conf.Id))
clonedConfig.PlatformId = platformID

labels := map[string]string{
Expand Down
Loading