psgi env: fix double encoding of path parts

[sparrow2009]

Fix double encoding of path parts when parsing a PSGI env with a SCRIPT_NAME set.

[kraih]

We use the use Mojo::Util qw(...) style everywhere now.

[sparrow2009]

A final note: This is actually a downstream patch in order to handle a race condition that is built into Mojo::Path::to_string().

my $path = ...;
Mojo::Path->new( $path )->to_string() # expects a decoded and unescaped $path as it encodes and escapes $path
my $path_obj = Mojo::Path->new( $path );
$path_obj->parts; # expects an encoded and escaped $path as it unescapes and decodes $path
$path_obj->to_string(); # encodes and escapes path parts

Thus if one happens to call to_string() on an object passed an encoded string on construction and did not call a method that _parse()d the string before double encoding occurs.

From reading the object construction examples listed in the synopsis of Mojo::Path I get the impression (correct me if I am wrong) that passing both encoded and decoded strings on object construction is valid and actually considered a feature. This design inevitably makes it impossible however to tell apart the nature of the construction string (encoded/decoded) later (and if my reasoning is correct can be considered a design flaw).

[Copilot]

Pull Request Overview

This PR addresses the double encoding issue of path parts when parsing a PSGI env with a SCRIPT_NAME set. The key changes include:

• Adding a test case that covers a UTF-8 path part scenario.
• Utilizing Mojo::Util’s encode and url_escape functions in tests.
• Invoking $path->parts in the request parser to address the encoding problem.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
t/mojo/request_cgi.t	New test for UTF-8 path parts and verification of roundtripping
lib/Mojo/Message/Request.pm	Adjusted environment parsing by calling $path->parts

Comments suppressed due to low confidence (1)

lib/Mojo/Message/Request.pm:200

• Consider adding an inline comment explaining why calling $path->parts at this point fixes the double encoding issue. This will help future maintainers understand the intent behind the call.

$path->parts;