Skip to content

Bugfix: ZapLine sampling rate mismatch & Changelog setup#17

Merged
BabaSanfour merged 6 commits intomne-tools:mainfrom
BabaSanfour:fix/core-updates
Feb 11, 2026
Merged

Bugfix: ZapLine sampling rate mismatch & Changelog setup#17
BabaSanfour merged 6 commits intomne-tools:mainfrom
BabaSanfour:fix/core-updates

Conversation

@BabaSanfour
Copy link
Copy Markdown
Member

- Restored DSS and ZapLine implementation from dev-benchmarch
- Added Towncrier changelog system and configuration
- Updated CONTRIBUTING.md with new guidelines
- Fixed ZapLine sampling rate mismatch bug (Issue mne-tools#16)
- Added adaptive ZapLine tests
@BabaSanfour BabaSanfour self-assigned this Feb 10, 2026
@BabaSanfour BabaSanfour added bug Something isn't working documentation Improvements or additions to documentation labels Feb 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.34%. Comparing base (db23c8f) to head (a2fed1d).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
mne_denoise/zapline/adaptive.py 86.66% 0 Missing and 2 partials ⚠️
mne_denoise/zapline/core.py 96.00% 0 Missing and 2 partials ⚠️
mne_denoise/dss/denoisers/spectral.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   89.71%   90.34%   +0.62%     
==========================================
  Files          32       32              
  Lines        2547     2588      +41     
  Branches      447      454       +7     
==========================================
+ Hits         2285     2338      +53     
+ Misses        153      144       -9     
+ Partials      109      106       -3     
Flag Coverage Δ
unittests 90.34% <94.11%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mne_denoise/dss/denoisers/temporal.py 100.00% <100.00%> (ø)
mne_denoise/dss/linear.py 96.72% <ø> (ø)
mne_denoise/dss/denoisers/spectral.py 99.00% <91.66%> (+9.62%) ⬆️
mne_denoise/zapline/adaptive.py 93.42% <86.66%> (+0.17%) ⬆️
mne_denoise/zapline/core.py 97.93% <96.00%> (+0.91%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread docs/changes/devel/17.bugfix.rst
@BabaSanfour
Copy link
Copy Markdown
Member Author

BabaSanfour commented Feb 11, 2026

Doc is failing due to an issue in mne-python related to tarfile security filters in Python 3.12+ (mne-tools/mne-python#13648). Will merge and close and bump mne version once fix is released.

@BabaSanfour BabaSanfour merged commit c219d3d into mne-tools:main Feb 11, 2026
15 of 16 checks passed
@BabaSanfour BabaSanfour deleted the fix/core-updates branch February 12, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ZapLine failure when sampling rate is not a multiple of line frequency

2 participants