Skip to content

Fixes dictionary registration of FilterEnsemble#988

Open
advieser wants to merge 3 commits intomasterfrom
fix_flt_ensemble_dict
Open

Fixes dictionary registration of FilterEnsemble#988
advieser wants to merge 3 commits intomasterfrom
fix_flt_ensemble_dict

Conversation

@advieser
Copy link
Copy Markdown
Collaborator

closes #985
Dependent on mlr-org/mlr3filters#185

@advieser
Copy link
Copy Markdown
Collaborator Author

Can think on whether we want to pass some default values or NAs for the custom fields of our in-place R6 class, although looking at as.data.table(mlr_filters), this does not seem to be handled consistently at the moment in any case.

@advieser advieser marked this pull request as ready for review March 23, 2026 09:05
@mb706
Copy link
Copy Markdown
Collaborator

mb706 commented Mar 23, 2026

feature_types etc. should be "all" feature types, not none -- look these up from mlr_reflections

@advieser
Copy link
Copy Markdown
Collaborator Author

Looking entries up from mlr_reflections would lead to different entries depending on package load order.

library(mlr3proba)
devtools::load_all("./mlr3filters")
devtools::load_all("./mlr3pipelines")
as.data.table(flt())[key == "ensemble"]$task_types
#[[1]]
#[1] "classif"      "dens"         "regr"         "surv"         "unsupervised"
devtools::load_all("./mlr3filters")
devtools::load_all("./mlr3pipelines")
library(mlr3proba)
as.data.table(flt())[key == "ensemble"]$task_types
#[[1]]
#[1] "classif"      "regr"         "unsupervised"

@be-marc
Copy link
Copy Markdown
Member

be-marc commented Apr 23, 2026

Sorry I overlooked this. You can close #990

@be-marc
Copy link
Copy Markdown
Member

be-marc commented Apr 23, 2026

Fix for mlr3filters should be on CRAN soon

@be-marc
Copy link
Copy Markdown
Member

be-marc commented Apr 23, 2026

New mlr3filters version is on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

as.data.table(mlr_filters) is broken

3 participants