Improve Relay Install (for libssl3 / zts)#1274
Merged
mlocati merged 3 commits intomlocati:masterfrom Apr 16, 2026
Merged
Conversation
… better check for libssl3. Test: relay
mlocati
reviewed
Apr 16, 2026
mlocati
reviewed
Apr 16, 2026
mlocati
reviewed
Apr 16, 2026
Contributor
Author
|
I should point out this is part of trying to get Relay to work with FrankenPHP using a Debian docker image. This doesn't fix the underlying problem but should make things work once Relay fixes another issue on their side. |
mlocati
reviewed
Apr 16, 2026
Owner
|
Thanks! |
|
@mlocati question about the tests. I am trying to understand how it works when a package has both NTS and ZTS versions, does it test both? |
Owner
Nope, we just run tests against the "default" CLI docker images (they are already so many that sometimes tests take more than 1 hour) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Relay extension by adding a check if ZTS should be used and a better check for libssl3.
Test: relay