Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Pins GitHub Action dependencies in CI and release workflows to immutable commit SHAs to improve supply-chain safety and reproducibility.
Changes:
- Pin
actions/checkoutto a specific commit SHA across test/build/lint/format and release workflows. - Pin
rust-lang/crates-io-auth-actionandswatinem/rust-cacheto specific commit SHAs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/test.yaml |
Pins actions/checkout to a commit SHA in all jobs. |
.github/workflows/release.yaml |
Pins actions/checkout and crates.io auth action to commit SHAs. |
.github/actions/setup/action.yaml |
Pins swatinem/rust-cache to a commit SHA (but leaves another action unpinned). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # spell-checker: disable-next-line | ||
| - uses: swatinem/rust-cache@v2 | ||
| - uses: swatinem/rust-cache@c676846f29d98ff6b0106d3608c7ffd4048af17b # v2.9.0 | ||
| - uses: homebrew/actions/setup-homebrew@master |
There was a problem hiding this comment.
homebrew/actions/setup-homebrew is still referenced via @master, which is a moving target and undermines the goal of pinning action versions (also a supply-chain risk). Pin this action to a specific commit SHA (and optionally annotate the intended release/tag in a comment) similar to the other actions in this PR.
Suggested change
| - uses: homebrew/actions/setup-homebrew@master | |
| - uses: homebrew/actions/setup-homebrew@93f46cc0bf0ee06b6ade24f1525c5e8f302ff628 # v3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.