Potential fix for #404 Too many variables when initializing the EmissionsTracker#1161
Open
Jmilk3 wants to merge 1 commit intomlco2:masterfrom
Open
Potential fix for #404 Too many variables when initializing the EmissionsTracker#1161Jmilk3 wants to merge 1 commit intomlco2:masterfrom
Jmilk3 wants to merge 1 commit intomlco2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modifies EmissionsTracker init functions to use **kwargs to address the large number of input arguments as suggested in issue #404. The implementation seeks to avoid changing anything about how the code actually runs while clearing the code smell.
How Has This Been Tested?
All existing tests still pass with no modifications after the changes to EmissionsTracker were implemented. All pre-commit linters/autoformatters passed.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:AI Usage Disclosure
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Notes:
I am unsure if/how the documentation should be updated to reflect the changes made to the argument input format. I would be happy to make those changes if needed.
This is my first attempt at contributing to an open source project, so any feedback would be greatly appreciated!