gui: Save pending track metadata before closing main window#16207
Open
Krish2882005 wants to merge 1 commit intomixxxdj:mainfrom
Open
gui: Save pending track metadata before closing main window#16207Krish2882005 wants to merge 1 commit intomixxxdj:mainfrom
Krish2882005 wants to merge 1 commit intomixxxdj:mainfrom
Conversation
Member
|
While this works as a quick fix, my feeling is that it's not that easy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16191
This PR makes sure Mixxx saves pending track metadata to the database before the main window completely closes. Previously, this happened in the background after closing, which could potentially cause database or config trouble if the app was restarted too quickly.
What changed: