Skip to content

gui: Save pending track metadata before closing main window#16207

Open
Krish2882005 wants to merge 1 commit intomixxxdj:mainfrom
Krish2882005:gui-exit-fix
Open

gui: Save pending track metadata before closing main window#16207
Krish2882005 wants to merge 1 commit intomixxxdj:mainfrom
Krish2882005:gui-exit-fix

Conversation

@Krish2882005
Copy link
Copy Markdown

Closes #16191

This PR makes sure Mixxx saves pending track metadata to the database before the main window completely closes. Previously, this happened in the background after closing, which could potentially cause database or config trouble if the app was restarted too quickly.

What changed:

  • Deactivates the track cache before the close event is accepted to trigger the metadata save.
  • Displays a "Saving Metadata" message box so the user knows to wait while the app finishes up.

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Mar 23, 2026

While this works as a quick fix, my feeling is that it's not that easy.
What can happen until the same, now redundant call from TrackCollectionManager::~TrackCollectionManager()?
And what about the other cleanup tasks in GlobalTrackCache::destroyInstance(), implicitly called by CoreServices::finalize()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notify if Mixxx is writing metadata to track file after closing MixxxMainWindow

2 participants