Skip to content

Use updated golang version in dockerfile#3202

Merged
deacon-mp merged 9 commits intomasterfrom
docker-golang
Oct 6, 2025
Merged

Use updated golang version in dockerfile#3202
deacon-mp merged 9 commits intomasterfrom
docker-golang

Conversation

@uruwhy
Copy link
Copy Markdown
Contributor

@uruwhy uruwhy commented Aug 28, 2025

Description

Dockerfile currently installs golang using apt, which only provides golang v1.19. To meet sandcat's minimum version of v1.24, the new Dockerfile will download and install golang v1.25 directly from the Go website.

Also fixes a bug where update-agents.sh contents are wiped during docker build.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Built docker locally and compiled agents using the update-agents.sh script

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@uruwhy uruwhy marked this pull request as ready for review August 28, 2025 20:23
@uruwhy uruwhy requested a review from clenk August 28, 2025 20:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 4, 2025

@sonarqubecloud
Copy link
Copy Markdown

@deacon-mp deacon-mp requested a review from Copilot September 29, 2025 23:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Golang installation in the Dockerfile from the outdated apt package (v1.19) to a direct download of v1.25 from the Go website to meet sandcat's minimum version requirement of v1.24. It also fixes a bug where the update-agents.sh script contents were being wiped during the Docker build process.

  • Downloads and installs Golang v1.25 directly from the official Go website
  • Fixes the update-agents.sh script corruption issue by creating a backup before processing
  • Removes the outdated golang-go package from apt installation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Dockerfile
Comment thread Dockerfile Outdated
uruwhy and others added 2 commits October 6, 2025 12:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 6, 2025

@deacon-mp deacon-mp merged commit 5849e3c into master Oct 6, 2025
13 checks passed
@deacon-mp deacon-mp deleted the docker-golang branch October 6, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants