Skip to content

filter 0-score facts from operation source #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkultraWasHere merged 2 commits into from
Apr 18, 2025
Merged

filter 0-score facts from operation source #3167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffda35c
filter 0-score facts from operation source
uruwhy Apr 16, 2025
b723aac
add 0-score fact to unit test
uruwhy Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/objects/c_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ async def all_facts(self):
seeded_facts = []
if self.source:
seeded_facts = await data_svc_handle.get_facts_from_source(self.source.id)
seeded_facts = [f for f in seeded_facts if f.score > 0]
learned_facts = await knowledge_svc_handle.get_facts(criteria=dict(source=self.id))
learned_facts = [f for f in learned_facts if f.score > 0]
return seeded_facts + learned_facts
Expand Down
2 changes: 1 addition & 1 deletion tests/objects/test_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def _make_agent(platform='windows', trusted=True, executor_name='psh'):

@pytest.fixture
def op_with_learning_and_seeded(ability, adversary, operation_agent, parse_datestring):
sc = Source(id='3124', name='test', facts=[Fact(trait='domain.user.name', value='bob')])
sc = Source(id='3124', name='test', facts=[Fact(trait='domain.user.name', value='bob'), Fact(trait='domain.user.name', value='jane', score=0)])
op = Operation(id='6789', name='testC', agents=[], adversary=adversary, source=sc, use_learning_parsers=True)
# patch operation to make it 'realistic'
op.start = parse_datestring(OP_START_TIME)
Expand Down
Loading