Skip to content

fix(frontend): まれにリアクション・絵文字ピッカーが動作しなくなる問題を修正#17349

Merged
syuilo merged 4 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-emoji-picker-1
Apr 30, 2026
Merged

fix(frontend): まれにリアクション・絵文字ピッカーが動作しなくなる問題を修正#17349
syuilo merged 4 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-emoji-picker-1

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Apr 29, 2026

What

Vite v8にあげてからiosなどの一部端末で絵文字ピッカー/リアクションピッカーが表示されない問題に対応

Why

Additional info (optional)

lqvp氏の端末で検証済?
https://misskey.io/notes/alnev3pcgily0c4o

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md 同一バージョンのため記載無し
  • (If possible) Add tests

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 29, 2026
@github-actions github-actions Bot added the packages/frontend Client side specific issue/PR label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 7.40741% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.91%. Comparing base (985de91) to head (3d9ed58).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/utility/reaction-picker.ts 7.40% 19 Missing and 6 partials ⚠️
packages/frontend/src/utility/emoji-picker.ts 8.00% 17 Missing and 6 partials ⚠️
packages/frontend/src/os.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17349      +/-   ##
===========================================
- Coverage    24.85%   14.91%   -9.94%     
===========================================
  Files         1150      242     -908     
  Lines        38847    11867   -26980     
  Branches     10785     4022    -6763     
===========================================
- Hits          9654     1770    -7884     
+ Misses       23424     7928   -15496     
+ Partials      5769     2169    -3600     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 29, 2026

/preview

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft April 29, 2026 12:43
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review April 29, 2026 12:49
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 30, 2026

/preview

@syuilo syuilo merged commit 973b5b5 into misskey-dev:develop Apr 30, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 Apr 30, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 30, 2026

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-emoji-picker-1 branch April 30, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants