Merged
Conversation
Also fix incorrect primitive conversion errors.
Contributor
Author
|
Tests pass locally and I can't see any details in the logs that would indicate what's wrong... |
Earthcomputer
approved these changes
May 19, 2025
Member
Earthcomputer
left a comment
Earthcomputer
left a comment
There was a problem hiding this comment.
Don't worry about the test failure, our tests have been failing intermittently lately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various Mixin/MixinExtras fixes, see individual commits.
I had a look into the issue with
@Shadowcompletion suggestions having their priority way too high but I didn't get that far, would appreciate if someone else could take a look at that one.