Open
Conversation
17 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces perceived UI latency in the Publish Database Project dialog when switching the publish target to New Local Docker by precomputing the first available container port in the background.
Changes:
- Preloads
findAvailablePort(...)as a backgroundPromise<number>when the publish command is invoked. - Threads the preloaded promise into
PublishProjectWebViewControllerand uses it when switching to the LocalContainer publish target. - Falls back to a live
dockerUtils.findAvailablePort(...)call when no preloaded promise is provided.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| extensions/mssql/src/controllers/mainController.ts | Starts port detection early and passes the resulting promise into the publish dialog controller. |
| extensions/mssql/src/publishProject/publishProjectWebViewController.ts | Accepts and uses a preloaded port promise to avoid blocking UI when switching to LocalContainer. |
Benjin
reviewed
Apr 16, 2026
PR Changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21928 +/- ##
==========================================
- Coverage 74.83% 74.82% -0.01%
==========================================
Files 392 392
Lines 118948 118989 +41
Branches 7065 7069 +4
==========================================
+ Hits 89015 89039 +24
- Misses 29933 29950 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the code and improves UI loading
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines