Merged
Conversation
added 15 commits
April 2, 2026 10:02
- Added constants for background tasks and related commands in constants.ts. - Integrated BackgroundTasksProvider and BackgroundTasksService in mainController.ts. - Implemented background task initialization and handling in MainController. - Enhanced SqlTasksService to register and manage background tasks. - Created unit tests for BackgroundTasksProvider, MainController, and SqlTasksService to ensure functionality. - Added logic for task completion, cancellation, and progress updates. - Implemented UI updates for background tasks in the VSCode extension.
… fabric provisioning logic - Updated `updateFabricProvisioningState` and `updateLocalContainersState` to use `publishDeploymentState` for state updates. - Enhanced local containers reducer to handle step completion more effectively, allowing for progress tracking across multiple steps. - Introduced new properties in `TaskInfo` and `TaskProgressInfo` for better task management and progress reporting. - Added support for resuming deployments with `resumedDeploymentType` and `resumedWizardPageId` in deployment state. - Implemented tests for background task synchronization and state updates in both local containers and fabric provisioning. - Improved user feedback during deployment processes with detailed progress messages and telemetry events.
- Removed unused stubs and tests related to background task handling in fabricProvisioningHelpers and localContainersHelpers tests. - Updated assertions to check for state updates instead of direct calls to publishDeploymentState. - Cleaned up localization files by removing obsolete entries and adding necessary translations for background tasks.
…, and target location
…e unused progress notifications
…c and updating tests for command execution
…date icon handling to use theme icons instead
aasimkhan30
requested review from
Benjin,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a first-class Background Tasks tree view to the Object Explorer pane and wires SQL Tools Service task lifecycle events into it (progress, cancel, completed result actions), addressing #21711.
Changes:
- Introduces
BackgroundTasksService/BackgroundTasksProvider/nodes to model and render background tasks in a dedicated tree view. - Updates
SqlTasksServiceto register/update/complete background tasks instead of using VS Code notification progress. - Adds localization strings + command contributions (open/cancel/clear-finished) and unit tests for new behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| localization/xliff/vscode-mssql.xlf | Adds new trans-units for background-task labels and elapsed-time formatting. |
| extensions/mssql/src/constants/locConstants.ts | Introduces localized helpers for task tooltip/elapsed-time strings. |
| extensions/mssql/src/constants/constants.ts | Adds view/command IDs for background tasks. |
| extensions/mssql/src/backgroundTasks/backgroundTasksService.ts | Implements background task registry, update/complete/cancel, ordering, trimming. |
| extensions/mssql/src/backgroundTasks/backgroundTasksProvider.ts | Implements TreeDataProvider + auto-reveal and periodic refresh for running tasks. |
| extensions/mssql/src/backgroundTasks/backgroundTaskNode.ts | Defines tree nodes, tooltip/description formatting, icons, context values. |
| extensions/mssql/src/services/sqlTasksService.ts | Integrates SQL task notifications with BackgroundTasksService and adds open/cancel handling. |
| extensions/mssql/src/controllers/mainController.ts | Initializes the view + commands, implements double-click-to-open semantics. |
| extensions/mssql/package.json | Contributes the tree view + commands/menus for background tasks. |
| extensions/mssql/package.nls.json | Adds command/view display names for localization. |
| extensions/mssql/l10n/bundle.l10n.json | Adds localized bundle entries for new background task strings. |
| extensions/mssql/test/unit/sqlTasksServiceBackgroundTasks.test.ts | Adds unit tests validating SQL task → background task integration. |
| extensions/mssql/test/unit/backgroundTasksProvider.test.ts | Adds unit tests for provider rendering, ordering, reveal, and commands. |
| extensions/mssql/test/unit/mainControllerBackgroundTasks.test.ts | Adds unit test for double-click behavior. |
| extensions/mssql/test/unit/sqlTasksService.test.ts | Enables sinon-chai assertions used by new tests. |
extensions/mssql/src/backgroundTasks/backgroundTasksProvider.ts
Outdated
Show resolved
Hide resolved
PR Changes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21833 +/- ##
==========================================
+ Coverage 73.80% 73.91% +0.11%
==========================================
Files 335 338 +3
Lines 101149 102102 +953
Branches 5821 5950 +129
==========================================
+ Hits 74655 75472 +817
- Misses 26494 26630 +136
🚀 New features to boost your workflow:
|
Benjin
reviewed
Apr 7, 2026
Benjin
previously approved these changes
Apr 7, 2026
| } | ||
|
|
||
| function applyTaskUpdate(task: BackgroundTaskEntry, update: BackgroundTaskUpdate): void { | ||
| if (Object.prototype.hasOwnProperty.call(update, "displayText") && update.displayText) { |
Contributor
There was a problem hiding this comment.
There's gotta be a way stick these in a loop
Benjin
reviewed
Apr 7, 2026
Benjin
reviewed
Apr 7, 2026
added 5 commits
April 7, 2026 15:41
…task management and error handling
…ility and logging
…me in HH:MM:SS format
…s for success and failure states
… registration and status updates
caohai
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
microsoft/sqltoolsservice@6.0.20260403.1...6.0.20260407.1
Adds a background task view to Object explorer pane. It will appear as new tree.
Fixes: #21711
Future PRs will contain:
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines