Filter backpanned favourites without truncating#1459
Merged
Conversation
oalders
force-pushed
the
oalders/metacpan-api/backpan-filter
branch
3 times, most recently
from
7f89f44 to
7506eb6
Compare
Improve by_user backpan filter so that we are more likely to get all user favorites rather than just a portion of them, for users with a lot of favorites.
oalders
force-pushed
the
oalders/metacpan-api/backpan-filter
branch
from
7506eb6 to
8d40b97
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
+ Coverage 62.16% 62.38% +0.21%
==========================================
Files 137 137
Lines 4393 4397 +4
Branches 659 660 +1
==========================================
+ Hits 2731 2743 +12
+ Misses 1410 1402 -8
Partials 252 252
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes treatment of users who have a long list of favourites and allows us to return a deduplicated list of all favourites rather than a sometimes truncated list.