Feat: Allow max timeout values to become zero, since zero means default.#10570
Open
h3lix1 wants to merge 1 commit into
Open
Feat: Allow max timeout values to become zero, since zero means default.#10570h3lix1 wants to merge 1 commit into
h3lix1 wants to merge 1 commit into
Conversation
Add a zero-sentinel timeout helper for config fields where 0 means default. Use it for PowerFSM screen_on_secs, min_wake_secs, and wait_bluetooth_secs so UINT32_MAX/MAX_INTERVAL can request immediate transitions. This change intentionally does not alter WiFi or Bluetooth runtime gating.
github-actions
Bot
added
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a zero-sentinel timeout helper for config fields where 0 means default. Use it for PowerFSM screen_on_secs, min_wake_secs, and wait_bluetooth_secs so UINT32_MAX/MAX_INTERVAL can request immediate transitions to low power state.
Apparently the codebase treats both UINT32_MAX and MAX_INTERVAL as different values that mean maximum due to Apple cleints.
This is part of the ESP32 Power Saving series of diffs.
🤝 Attestations
Seed Xiao Wio esp32-s3