fix(enketo): silence false-positive 'no context element found' errors#10962
Open
sh1vam31 wants to merge 2 commits intomedic:masterfrom
Open
fix(enketo): silence false-positive 'no context element found' errors#10962sh1vam31 wants to merge 2 commits intomedic:masterfrom
sh1vam31 wants to merge 2 commits intomedic:masterfrom
Conversation
- Fix race condition in message-duplicates integration test - Add github-token to k3d setup to resolve CI rate limiting
Contributor
Author
|
Hi @jkuester, This PR resolves #9684 by patching enketo-core to handle missing context nodes gracefully. This silences the false-positive "no context element found" console errors that were occurring during repeat group updates. I have also included some minor CI and test stability fixes to ensure all checks pass. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9684
This PR implements a patch for enketo-core to resolve a persistent "no context element found" console error. The error occurs when adding or removing entries in a repeat group while another repeat group in the same form is empty and contains fields with relevant expressions.
Solution
When a repeat group's instances change, Enketo triggers a global update that re-evaluates expressions for all fields. If a different repeat group is empty, Enketo's evaluate function fails to find a context node for its fields, resulting in a false-positive console error.
The patch modifies FormModel.prototype.evaluate to:
Patch Verification:
Code review checklist
can_view_old_navigationpermission to see the old design. Test it has appropriate design for RTL languages.License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.