chore(#10543): add PERSON contact type constant and replace magic strings

[gmarav05]

Description

Adds PERSON constant to the CONTACT_TYPES object in the shared constants library, replacing the magic string 'person' with a named constant.

Closes #10543

Code review checklist

• Readable: Concise, well named, follows the style guide
• Tested: Unit and/or e2e where appropriate
• AI disclosure: Used AI assistance for guidance on implementation

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[dianabarsan]

@gmarav05 as with #10747, the occurences of the magic string also need to be updated to use the constant. adding the constant is not sufficient. #

[gmarav05]

@gmarav05 as with #10747, the occurences of the magic string also need to be updated to use the constant. adding the constant is not sufficient. #

yeah sure i will soon update this. Sorry I was busy in college exams since 2 days. Now, I can finally start contributing again.

[dianabarsan]

@gmarav05 no worries! Your contributions are most welcome!

I did a spree where I took all PRs that didn't have comments or reviews, to make sure nobody is left hanging without a response. It wasn't meant to communicate urgency.

Good luck with exams!!!

[gmarav05]

Hello @sugat009, Should i make changes in all the files like tests/integration/ and tests/e2e/

[sugat009]

Hello @sugat009, Should i make changes in all the files like tests/integration/ and tests/e2e/

yes

[gmarav05]

Hello @sugat009, I tried to replace most of them. However I left few intentionally like these

please let me know if i should change anything or update anything.

[sugat009]

@gmarav05 Good call leaving those out. The _id: 'person' instances are arbitrary document identifiers in test fixtures, not contact type references. They should stay as literal strings.

However, please also leave the config/ files (config/default/, config/demo/, config/covid-19/) unchanged. These are reference configuration templates that CHT implementers copy into their own projects, where @medic/constants may not be available. Adding that dependency makes the configs non-portable. The '!person' negation patterns in those same files also can't use the constant cleanly, which creates inconsistency within the same file.

Focus the constant replacement on production source code and their corresponding tests where 'person' is used as a type or contact_type value.

[sugat009]

@gmarav05 The PR title appears to be incorrect. It currently says chore(#10540): add PARTNERS document type constant but this PR adds the PERSON constant to CONTACT_TYPES and closes #10543.

Please update it to something like: chore(#10543): add PERSON contact type constant and replace magic strings

[gmarav05]

Thanks for the detailed feedback @sugat009 , I have reverted all changes in the config/ directories (config/default, config/demo, config/covid-19) to keep them as literal strings and also limited the use of the PERSON constant.

Please let me know if any changes are required or feedback.

[gmarav05]

Hello @sugat009, Can you please re-run the failing CI checks.

The errors are not related to the PERSON constant changes and the hydration.spec.js failure may be a flaky integration test. When I ran CI tests locally all unit tests are passing.

[gmarav05]

Sorry @sugat009, I was self reviewing few from files changed tab and found that i replaced few test files with type: to appliesToType: CONTACT_TYPES.PERSON. I have now fixed that. 😅

[gmarav05]

hello @sugat009, Can you please re-trigger this check again, earlier it passed now after update it is failing again.

[gmarav05]

Hello @sugat009, the 'Compile the app' CI check failed due to a ShellCheck binary download rate limit error. Can you please re-trigger this check again, earlier it passed now after update it is failing again.

[sugat009]

Hello @sugat009, the 'Compile the app' CI check failed due to a ShellCheck binary download rate limit error. Can you please re-trigger this check again, earlier it passed now after update it is failing again.

sure

[dianabarsan]

Sorry for the delay @gmarav05 . I will prioritize this review tomorrow.

[gmarav05]

Sorry for the delay @gmarav05 . I will prioritize this review tomorrow.

No problem @dianabarsan, please review it when you have time.

[dianabarsan]

Very very nice! Almost perfect! Just a few comment inline.

[gmarav05]

Thanks for the detailed review @dianabarsan, I have addressed all the feedback and removed redundant local constants, reverted the doc-id usages back to literal strings and fixed the _id case in rules-engine spec.

Please let me know if any changes are required.

[gmarav05]

hello @dianabarsan, can you please review this PR when you are free.

[gmarav05]

Hello @dianabarsan, conflicts resolved and PR is up to date. Ready for review.

[gmarav05]

Hello @dianabarsan, Can you please review this PR when you are free.

[dianabarsan]

Thanks for the changes. I did a quick go-through and found some misses and inconsistencies. The naming inconsistency that I flagged, please apply it in all files where present, not just the one I added a comment for.

Thanks!

[gmarav05]

Hello @dianabarsan, I have addressed the feedback and updated everything. Can you please review this PR when you are free.

Also there are others PR as well please take a look when you are free.

Thank you.